Add Helm chart unit tests for Deployment and MySQL StatefulSet#164
Open
devin-ai-integration[bot] wants to merge 1 commit intoDevOpsfrom
Open
Add Helm chart unit tests for Deployment and MySQL StatefulSet#164devin-ai-integration[bot] wants to merge 1 commit intoDevOpsfrom
devin-ai-integration[bot] wants to merge 1 commit intoDevOpsfrom
Conversation
- Update Chart.yaml with correct description and appVersion - Add deployment_test.yaml covering metadata, labels, replicas, init container, app container image/port, env vars, probes, resources, and custom overrides - Add mysql_statefulset_test.yaml covering metadata, serviceName, labels, container image/port, env vars, volume mount, probes, VCT, and custom overrides - Add Testing section to helm/README.md with plugin install and run instructions Co-Authored-By: Shawn Azman <shawn.d.azman@gmail.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds helm-unittest coverage for the two core templates in
helm/bankapp/and cleans upChart.yaml.Chart.yaml — replaced boilerplate scaffold with a concise, project-specific definition (updated
description, changedappVersionfrom"1.16.0"→"1.0.0").Tests (41 tests, 2 suites — all passing locally):
tests/deployment_test.yaml— metadata/namespace, labels, replicas, init container (wait-for-mysql/busybox:1.28), app container image & port, env var sources (configMapKeyRef / secretKeyRef), liveness & readiness probes, resource requests/limits, and custom value overrides (image, resources, name, namespace).tests/mysql_statefulset_test.yaml— metadata/namespace, serviceName, labels, replicas, container image & port, env var sources, volume mount, liveness & readiness probes (execmysqladmin ping), volumeClaimTemplate (name, accessMode, storage), and custom value overrides (name, storage).README — added a "Testing" section with plugin install and run commands.
Review & Testing Checklist for Human
appVersionchange is safe:appVersionwas changed from"1.16.0"to"1.0.0". Confirm no template inhelm/bankapp/templates/references.Chart.AppVersion(e.g., for image tags or annotations) — if one does, this change could alter rendered manifests.SPRING_DATASOURCE_PASSWORDuses hardcoded secret name: The deployment template hardcodesname: mysql-secretfor the secretKeyRef rather than using{{ .Values.secret.name }}. The test correctly mirrors this, but it's a pre-existing inconsistency worth being aware of.helm unittest helm/bankapp/locally to confirm all 41 tests pass in your environment.Notes
helm plugin install https://github.com/helm-unittest/helm-unittest).Link to Devin session: https://app.devin.ai/sessions/e46575a271ab46e7b58b5b5db0e71dd4
Requested by: @ShawnAzman